Wrong version numbers for vscodium

leon-erd commented 6 months ago

Continuation of https://github.com/nix-community/nix4vscode/issues/18.

leon-erd commented 6 months ago

I already put this

{
  "extensionsGallery": {
    "serviceUrl": "https://marketplace.visualstudio.com/_apis/public/gallery",
    "itemUrl": "https://marketplace.visualstudio.com/items",
    "cacheUrl": "https://vscode.blob.core.windows.net/gallery/index",
    "controlUrl": ""
  }
}

in my ~/.config/VSCodium/product.json as described in https://github.com/VSCodium/vscodium/blob/master/docs/index.md#extensions-marketplace so I'm assuming that I already use vscode marketplace.

Or what do you mean with using vscode marketplace instead of openvsx?

cathaysia commented 6 months ago

Sorry, I just tried it and it is indeed my problem. Now it should work fine

leon-erd commented 6 months ago

What do you mean "now it should work fine"?

cathaysia commented 6 months ago

yes

From: Leon @.> Sent: Monday, March 11, 2024 7:16:40 AM To: nix-community/nix4vscode @.> Cc: DragonBillow @.>; State change @.> Subject: Re: [nix-community/nix4vscode] Wrong version numbers for vscodium (Issue #23)

What do you mean "now it should work fine"?

― Reply to this email directly, view it on GitHubhttps://github.com/nix-community/nix4vscode/issues/23#issuecomment-1987402516, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKBJ6ALDMFU2H6QRAO62HDDYXTSVRAVCNFSM6AAAAABEOPHE6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBXGQYDENJRGY. You are receiving this because you modified the open/close state.Message ID: @.***>

cathaysia commented 6 months ago

this issue should be fixed on master

From: 张龙涛 @.> Sent: Monday, March 11, 2024 7:34:50 AM To: nix-community/nix4vscode @.>; nix-community/nix4vscode @.> Cc: State change @.> Subject: Re: [nix-community/nix4vscode] Wrong version numbers for vscodium (Issue #23)

yes

From: Leon @.> Sent: Monday, March 11, 2024 7:16:40 AM To: nix-community/nix4vscode @.> Cc: DragonBillow @.>; State change @.> Subject: Re: [nix-community/nix4vscode] Wrong version numbers for vscodium (Issue #23)

What do you mean "now it should work fine"?

― Reply to this email directly, view it on GitHubhttps://github.com/nix-community/nix4vscode/issues/23#issuecomment-1987402516, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKBJ6ALDMFU2H6QRAO62HDDYXTSVRAVCNFSM6AAAAABEOPHE6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBXGQYDENJRGY. You are receiving this because you modified the open/close state.Message ID: @.***>

nix-community / nix4vscode

Wrong version numbers for vscodium #23