search

nix-community / nixGL

A wrapper tool for nix OpenGL application [maintainer=@guibou]
677 stars 78 forks source link

`name` of `nvidiaDrivers` and `nvidiaLibsOnly` is wrong #92

Closed jian-lin closed 2 years ago

jian-lin commented 2 years ago

linuxPackages.nvidia_x11 doesn't use pname, instead it sets name = "nvidia-x11-${version}${nameSuffix}";.

However, we only set pname and version in our overrideAttrs, which doesn't change the original name.

Do we need to keep the same name structure with linuxPackages.nvidia_x11? If so, the fix for nvidiaLibsOnly is simple. But it's not simple to fix nvidiaDrivers, since it contains nameSuffix, which is defined by nameSuffix = optionalString (!libsOnly) "-${kernel.version}";.

guibou commented 2 years ago

Hello,

Thank you for opening this ticket.

I just override the name to "nvidia-x11-${version}" and I'm happy with that.

Please reopen if you would like another solution.