Closed cambid closed 7 years ago
WTF ruby
On Sat, 25 Feb 2017, 23:49 Jan Fader, notifications@github.com wrote:
@cambid commented on this pull request.
In gen_template.rb https://github.com/zimbatm/nixbox/pull/20#discussion_r103089357:
) end
main
arch = ARGV[0] || fail('usage: gen_template.rb
') -isos = JSON.load(open('iso_urls.json'), nil, symbolize_names: true) Yes, but unfortunately ":symbolize_names and :create_additions cannot be used in conjunction" and the default for create_additions is switched to true in ruby >=2.0
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/zimbatm/nixbox/pull/20#discussion_r103089357, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAMsL4Ccd3c0ISgzrEIQ7TcmM2peziSks5rgKIFgaJpZM4MMDWn .
Sorry I can't accept this PR as it is. Let me know if you want to pursue this or I should close it.
This pull requests make gen_template.rb compatible to ruby >= 2.0 and remove the code for the atlas-push from gen_template.rb to be consistent across both archs (x86_64 and i686)