search

nix-community / nixbox

NixOS Vagrant boxes [maintainer=@ifurther]
https://app.vagrantup.com/nixbox/
MIT License
309 stars 101 forks source link

Creating travis config to build both boxes with packer. #5

Closed Tzrlk closed 8 years ago

Tzrlk commented 8 years ago
zimbatm commented 8 years ago

Doesn't atlas support the github integration itself ?

zimbatm commented 8 years ago

Just checked, atlas offers integration but wants full admin rights on public and private repos

zimbatm commented 8 years ago

@Tzrlk sorry for the wait, I am still pondering on what the best approach is.

Right now Atlas only works for the x86_64 arch for some reason so I still have to build the other box by hand anyways and running packer push file.json is not too much of a hassle.

What would be nice is to have PR automatically validate some of the structure of the project like the .json format and make sure the Makefile has been run.

Tzrlk commented 8 years ago

Does the Atlas integration support building pull requests? That's the main benefit I see from using travis. It'll actually give you build status notifications.

On Tue, 20 Oct 2015 at 02:17 zimbatm notifications@github.com wrote:

@Tzrlk https://github.com/Tzrlk sorry for the wait, I am still pondering on what the best approach is.

Right now Atlas only works for the x86_64 arch for some reason so I still have to build the other box by hand anyways and running packer push file.json is not too much of a hassle.

What would be nice is to have PR automatically validate some of the structure of the project like the .json format and make sure the Makefile has been run.

— Reply to this email directly or view it on GitHub https://github.com/zimbatm/nixbox/pull/5#issuecomment-149210759.

zimbatm commented 8 years ago

Answering with another question: is it possible to run the builds without uploading the artifacts ? I don't want PRs to replace existing images.

Atlas requires too many permissions that I feel comfortable to attach to my account.

On Mon, 19 Oct 2015 23:50 Peter Cummuskey notifications@github.com wrote:

Does the Atlas integration support building pull requests? That's the main benefit I see from using travis. It'll actually give you build status notifications.

On Tue, 20 Oct 2015 at 02:17 zimbatm notifications@github.com wrote:

@Tzrlk https://github.com/Tzrlk sorry for the wait, I am still pondering on what the best approach is.

Right now Atlas only works for the x86_64 arch for some reason so I still have to build the other box by hand anyways and running packer push file.json is not too much of a hassle.

What would be nice is to have PR automatically validate some of the structure of the project like the .json format and make sure the Makefile has been run.

— Reply to this email directly or view it on GitHub https://github.com/zimbatm/nixbox/pull/5#issuecomment-149210759.

— Reply to this email directly or view it on GitHub https://github.com/zimbatm/nixbox/pull/5#issuecomment-149369724.

Tzrlk commented 8 years ago

Yeah, that's the idea. It only deploys on tags.

On Tue, 20 Oct 2015 at 23:01 zimbatm notifications@github.com wrote:

Answering with another question: is it possible to run the builds without uploading the artifacts ? I don't want PRs to replace existing images.

Atlas requires too many permissions that I feel comfortable to attach to my account.

On Mon, 19 Oct 2015 23:50 Peter Cummuskey notifications@github.com wrote:

Does the Atlas integration support building pull requests? That's the main benefit I see from using travis. It'll actually give you build status notifications.

On Tue, 20 Oct 2015 at 02:17 zimbatm notifications@github.com wrote:

@Tzrlk https://github.com/Tzrlk sorry for the wait, I am still pondering on what the best approach is.

Right now Atlas only works for the x86_64 arch for some reason so I still have to build the other box by hand anyways and running packer push file.json is not too much of a hassle.

What would be nice is to have PR automatically validate some of the structure of the project like the .json format and make sure the Makefile has been run.

— Reply to this email directly or view it on GitHub https://github.com/zimbatm/nixbox/pull/5#issuecomment-149210759.

— Reply to this email directly or view it on GitHub https://github.com/zimbatm/nixbox/pull/5#issuecomment-149369724.

— Reply to this email directly or view it on GitHub https://github.com/zimbatm/nixbox/pull/5#issuecomment-149504017.

zimbatm commented 8 years ago

Hey, sorry for not keeping-up on that.

I just setup the Atlas integration so Travis is not needed. I'll go ahead and close the issue but feel free to comment and I'll re-open it if you think this should still be tackled.