search

nix-community / nixops-gce

NixOps Google Cloud Backend
25 stars 8 forks source link

Example for custom bootstrap image #16

Closed tewfik-ghariani closed 3 years ago

tewfik-ghariani commented 3 years ago

Fix the support for custom bootstrap image

machine = {
  deployment.gce = {
    bootstrapImage.name = resources.gceImages.custom-image;
  };
}

Ref to https://github.com/nix-community/nixops-gce/pull/12

@talyz Hope this makes sense, I believe this was the consensus as discussed per https://github.com/nix-community/nixops-gce/pull/9 but if you think we should change it, please let me know

talyz commented 3 years ago

I don't really see the issue being discussed in #9. Splitting out the options to a submodule in its own file is what I see and it makes sense to me, but I still think

machine = {
  deployment.gce = {
    bootstrapImage = resources.gceImages.custom-image;
  };
}

should work. It's backwards compatible and makes more sense to me semantically.

tewfik-ghariani commented 3 years ago

You are correct @talyz

Updated this PR to add a simple example file

Thanks again!

PS This should also close https://github.com/nix-community/nixops-gce/issues/15

FYI @AmineChikhaoui