search

nix-community / nixops-libvirtd

NixOps libvirtd backend plugin [maintainer=@AmineChikhaoui]
GNU Lesser General Public License v3.0
35 stars 20 forks source link

Volume upload: use the correct file size #17

Closed grahamc closed 4 years ago

grahamc commented 4 years ago

re #8 and https://bugs.launchpad.net/qemu/+bug/1881648 -- uploads fail if the host filesystem uses compression.

grahamc commented 4 years ago

This last commit closes #8 almost for sure, since:

  1. it no longer copies the qcow2 to a tmpdir, and uploads directly from the store
  2. it now correctly accounts for filesystems which do compression

which should cover all the mysterious cases we've seen for out-of-space errors.

adisbladis commented 4 years ago

I can't say I grok what allocation is supposed to represent, but I guess LGTM and seems to work just fine.

It would be great with some clarification, FWIW here are the relevant docs: https://libvirt.org/formatstorage.html#StoragePoolFirst.