search

nix-community / nixops-libvirtd

NixOps libvirtd backend plugin [maintainer=@AmineChikhaoui]
GNU Lesser General Public License v3.0
35 stars 20 forks source link

Update libvirt-python to 7.x #28

Closed max-privatevoid closed 2 years ago

max-privatevoid commented 2 years ago

libvirt-python is currently locked at 6.10.0 and won't be autobumped any higher by re-locking. Since libvirt 7.x is in use in nixpkgs, it's probably advisable to update the dependency to match. https://github.com/NixOS/nixpkgs/pull/130805 wants to update libvirt to 7.6.0, which results in a build failure for libvirt-python-6.10.0 when trying to build nixopsUnstable.

The plan is to update the dependency here and then run the update script for NixOps in nixpkgs. https://github.com/max-privatevoid/nixpkgs/commit/961128403f1268a0a1dc8d6fb88205deeb1c274f is based off the aforementioned PR and applies the changes that would be taken after my PR here gets merged. nixopsUnstable builds successfully with the following command, but no further testing was done so far.

nix build github:max-privatevoid/nixpkgs/bump-libvirt-python-fork#nixopsUnstable
Artturin commented 2 years ago

@adisbladis @AmineChikhaoui @grahamc

max-privatevoid commented 2 years ago

CI failure unrelated