search

nix-community / nixos-generators

Collection of image builders [maintainer=@Lassulus]
MIT License
1.67k stars 134 forks source link

Upstream virtualization fix sprint #103

Open blaggacao opened 3 years ago

blaggacao commented 3 years ago

I've noticed that some upstream modules under nixos/modules/virtualisation are actually in pretty bad shape.

To gather and coordinate a fixing sprint, I've just setup https://matrix.to/#/!LhhFDmfZUkcXRvvvxM:matrix.org?via=matrix.org&via=nordgedanken.dev

Please join if you're interested.

I open this issue here, since I assume several users of nixos-generators have vested interests in the possible outcomes of this.

@Lassulus It would be really amazing if we could somehow team up to push this agenda. (together with other stranded devos users)

Lassulus commented 3 years ago

sounds good, I'm currently fighting against my matrix setup, so as soon as I have that figured out I can join the channel :D

blaggacao commented 2 years ago

This was a first item:

https://github.com/NixOS/nixpkgs/pull/131760

@Lassulus I think your mkOverride 60 suggestion sets a very good precedent on how to make those class of modules aggregable to existing host configs without generating any kind of conflict (neither with normal host config, nor with conscientiously targeted overrides for any specific image).

Lassulus commented 2 years ago

here is a recent addition of mine: https://github.com/NixOS/nixpkgs/pull/131312 maybe we should think about a common interface we want to export in every module. currently some modules don't even have any options and the ones which have some are very different.