nix-community / nixos-install-scripts

collection of one-shot scripts to install NixOS on various server hosters and other hardware. [maintainer=@happysalada]
123 stars 68 forks source link

Support parted 3.3 exiting 1 on kernel inform failure #10

Closed nh2 closed 2 years ago

nh2 commented 2 years ago

Fixes #9.

happysalada commented 2 years ago

I don't have a machine at hand to test unfortunately. However, looking briefly at the PR I don't see any problem.

happysalada commented 2 years ago

Testing now and I'm getting the following bash: warning: setlocale: LC_ALL: cannot change locale (en_CA.UTF-8)

the whole output is like

./parted-ignoring-partprobe-error.sh --script $DISK2 mklabel gpt
bash: warning: setlocale: LC_ALL: cannot change locale (en_CA.UTF-8)
This is expected, continuing
happysalada commented 2 years ago

this has nothing to do with what you made though, so let's merge. I'll go through the script again and make some updates.

happysalada commented 2 years ago

Thank you!