search

nix-community / nixos-install-scripts

collection of one-shot scripts to install NixOS on various server hosters and other hardware. [maintainer=@happysalada]
127 stars 68 forks source link

Dedicated Hetzner config hardcodes ipv4 prefix length #13

Closed bitonic closed 3 years ago

bitonic commented 3 years ago

The script to install on dedicated Hetzner assumes a prefix length of 24, or in other words netmask 255.255.255.0: https://github.com/nix-community/nixos-install-scripts/blob/cb09b52de856eb561d2b6db50c045c0ce58d75f5/hosters/hetzner-dedicated/hetzner-dedicated-wipe-and-install-nixos.sh#L247 .

However this is not the case for the server I just rented, where the netmask is 255.255.255.192 -- that is, prefix 26.

I fixed it manually, but we should either:

  1. Adjust the grep invocations to get that info too;
  2. Add a FIXME

I can easily do the latter, if you guys think it's appropriate.

happysalada commented 3 years ago

number 2 sounds like a great idea! (feel free to ping me on your PR). Great that you found this!