search

nix-community / nixos-install-scripts

collection of one-shot scripts to install NixOS on various server hosters and other hardware. [maintainer=@happysalada]
123 stars 68 forks source link

hetzner: add FIXME placeholders #6

Closed asymmetric closed 3 years ago

asymmetric commented 3 years ago

To make the necessary edits easier to find.

asymmetric commented 3 years ago

I actually don't understand if the mdadm homehost should also be kept in sync with the hostname - if so, then we should add FIXMEs there too.

happysalada commented 3 years ago

I think so, but I have never gone fully through that tutorial. @nh2 should know, when he has a moment to review.

asymmetric commented 3 years ago

I think I understand the comments better now, homehost is supposed to stay unchanged, since it was first set by Hetzner to hetzner.

@nh2 true story?

happysalada commented 3 years ago

After checking, the default hostname on a hetzner machine is not hetzner you can check this by doing hostname I think this value should be replaced with your default hostname, for example mine is Ubuntu-2010-groovy-64-minimal Note that it should not be the hostname you will set in the future, but the current hostname. (that is my understanding)

happysalada commented 3 years ago

Also just noticed, but we can probably update the stable to 20.09 instead of 03

happysalada commented 3 years ago

I discovered a small typo in # Relaod partitions in case you are interested in adding it to the PR

happysalada commented 3 years ago

Also maybe add a comment about installing parted ?

happysalada commented 3 years ago

I just thought about this, but how about adding some environment variables at the begining of the script to make clearer what needs to be relplaced. And then throught the code you only have $MY_HOSTNAME or $MY_SSH_KEY I felt the /dev/sda and /dev/sdb need to be replaced also. How about abstracting those to $DISK_1 and $DISK_2?

last solution would be to have arguments for the script.

happysalada commented 3 years ago

@asymmetric I now have commit rights, if you are still interested in this, let me know and I can write a detailed set of things to change so we can try to merge this together. I know this has been a while, so no worries if you have moved on.

asymmetric commented 3 years ago

@happysalada congrats on the commit bit!

I think we could merge this one (as it's trivial) and iterate on other (possibly breaking) changes separately.

WDYT?

happysalada commented 3 years ago

Agreed, since it's only editing the comments. I think a better long terme approach would probably be to pass variables to the script. We can provide this improvement later.

happysalada commented 3 years ago

@asymmetric Thank you for your contribution!