nix-community / nixpkgs-update

Updating nixpkgs packages since 2018
Creative Commons Zero v1.0 Universal
434 stars 70 forks source link

Error updating one package #261

Open asymmetric opened 3 years ago

asymmetric commented 3 years ago

Running nixpkgs-update as a flake, getting the following error:

❯ nix run github:ryantm/nixpkgs-update -- update "polkadot 0.8.30 0.9.0"
Configured Nixpkgs-Update Options:
----------------------------------
GitHub User:                   r-ryantm
Send pull request on success:  NO
Calculate Outpaths:            NO
CVE Security Report:           NO
Run nixpkgs-review:            NO
Nixpkgs Dir:                   "/home/asymmetric/code/nixpkgs"
----------------------------------
Received ExitFailure 128 when running
Raw command: /nix/store/4rpj61dvrcby1r8adiy0z5iqabqfjlif-git-2.29.2/bin/git show remotes/upstream/master:pkgs/applications/blockchains/polkadot/default.nix
Standard output:

fatal: invalid object name 'remotes/upstream/master'.
Standard error:

fatal: invalid object name 'remotes/upstream/master'.

Which repo is being queried for a remote named upstream?

nh2 commented 3 years ago

Can confirm.

I suspect this is fromhttps://github.com/ryantm/nixpkgs-update/issues/137#issue-548704095

[ ] upstream remote is not set up

Workaround in your nixpkgs checkout:

git remote add upstream https://github.com/NixOS/nixpkgs.git
git fetch upstream
asymmetric commented 3 years ago

Looking at https://github.com/ryantm/nixpkgs-update/blob/c1537fbba57e61ada042863b39c3616529691475/src/Git.hs, there are in fact a number of hard-coded references to upstream. My Haskell chops are unfortunately non-existent, so I don't understand what's actually going on.