nix-community / nixpkgs-wayland

Automated, pre-built packages for Wayland (sway/wlroots) tools for NixOS. [maintainers=@colemickens, @Artturin]
510 stars 47 forks source link

Update xdg-desktop-portal-wlr & hack path for iniparser #284

Closed b333z closed 3 years ago

b333z commented 3 years ago

auto-update(manual): xdg-desktop-portal-wlr: e103e120e20e83acec5b66ce4cd33a0eb86df0b0 => ab8ff54f4c3e564595afefbcbdd6c87e2c8188f5

Prior to this change, this package was pinned due to newer commits referencing library: iniparser which is not distributed with a pkg-config causing the build to fail on nix systems.

This change hacks around the problem by doing a replacement in meson.build to cc.findlibrary(..) on the iniparser location in the nix store.

Fixes: #283

b333z commented 3 years ago

I stumbled through this recently when I switched to the "Add graphical display chooser" PR which I am in need of that is still to land but had the iniparser dep. So this is quite hacky, understand if we don't want to merge, but wanted to share in case useful.

Thanks @colemickens & to all the contributors for this work, it's greatly appreciated!

berbiche commented 3 years ago

Can be closed with https://github.com/NixOS/nixpkgs/pull/116146?

b333z commented 3 years ago

Yep looks good to close.