Closed Artturin closed 1 year ago
The update script relies on
repo_git
andrepo_hg
attributes to know whether to try to update using git or mercurial.glpaper's is wrong, for example. It might be worth removing
repo_git
andrepo_hg
and using thetype
field you've added.
fixed, let's revisit using the type field in a future pr
We'll still need the composed URL to hand to git ls-remote
etc, so it certainly feels like a ideological/cleanup fix, but I won't stop you if you want to follow up with it. Otherwise this looks good. Everything builds when I peel back the {current messy set}.
Will merge in a minute, one last look.
I guess I might consider hoisting out some of the extra helpers and functions since they don't need prev
or final
, but that feels petty/stylistic, I could see someone arguing its only needed in the context of waylandOverlay anyway...
This is great, thanks @Artturin, lez go.
The update script relies on
repo_git
andrepo_hg
attributes to know whether to try to update using git or mercurial.glpaper's is wrong, for example. It might be worth removing
repo_git
andrepo_hg
and using thetype
field you've added.