nix-community / nixpkgs-wayland

Automated, pre-built packages for Wayland (sway/wlroots) tools for NixOS. [maintainers=@colemickens, @Artturin]
502 stars 45 forks source link

make genPackages #360

Closed Artturin closed 1 year ago

colemickens commented 1 year ago

The update script relies on repo_git and repo_hg attributes to know whether to try to update using git or mercurial.

glpaper's is wrong, for example. It might be worth removing repo_git and repo_hg and using the type field you've added.

Artturin commented 1 year ago

The update script relies on repo_git and repo_hg attributes to know whether to try to update using git or mercurial.

glpaper's is wrong, for example. It might be worth removing repo_git and repo_hg and using the type field you've added.

fixed, let's revisit using the type field in a future pr

colemickens commented 1 year ago

We'll still need the composed URL to hand to git ls-remote etc, so it certainly feels like a ideological/cleanup fix, but I won't stop you if you want to follow up with it. Otherwise this looks good. Everything builds when I peel back the {current messy set}.

Will merge in a minute, one last look.

colemickens commented 1 year ago

I guess I might consider hoisting out some of the extra helpers and functions since they don't need prev or final, but that feels petty/stylistic, I could see someone arguing its only needed in the context of waylandOverlay anyway...

colemickens commented 1 year ago

This is great, thanks @Artturin, lez go.