search

nix-community / nixpkgs-wayland

Automated, pre-built packages for Wayland (sway/wlroots) tools for NixOS. [maintainers=@colemickens, @Artturin]
502 stars 45 forks source link

swww: init at 0.1.7 #393

Closed cmacrae closed 1 year ago

cmacrae commented 1 year ago

These changes replace oguri with swww, as oguri is no longer maintained.

Fixes #389

As noted in the package definition, swww has tests that rely on a wayland env and attempts to connect to the socket.
To get a successful build I set doCheck = false for now. Is there a common convention for this case?

colemickens commented 1 year ago

I'm not sure if there's a ton better solution. Is there a way to tell cargo to only skip some tests? Or do all of them behave the same?

cmacrae commented 1 year ago

@colemickens Not as far as I can tell, without annotating the tests themselves. Possible with patches, of course, but seems a bit overkill. We may have to just live with doCheck = false, if that's acceptable?

colemickens commented 1 year ago

That's fine with me. Maybe if it merges into nixpkgs at some point someone will come up with something we can borrow.

colemickens commented 1 year ago

Thanks!

devhell commented 1 year ago

Thank you!