waybar: consider dropping

nix-community / nixpkgs-wayland

Automated, pre-built packages for Wayland (sway/wlroots) tools for NixOS. [maintainers=@colemickens, @Artturin]

522 stars 46 forks source link

waybar: consider dropping #449

Open colemickens opened 5 months ago

colemickens commented 5 months ago

It looks like upstream waybar has a flake. I also seem to be having a build failure from our waybar.

It's tempting to drop it with a note that users should migrate to the upstream flake.

Artturin commented 5 months ago

What failure

colemickens commented 5 months ago

They bumped up the version of cava needed. We use the nixpkgs derivation, which has the older version baked in.

colemickens commented 5 months ago

basically:

(recent cava related commits)
https://github.com/NixOS/nixpkgs/blob/6990439a4a194ed8f6f7a4a594740dc01153cf91/pkgs/by-name/wa/waybar/package.nix#L73-L78

Artturin commented 5 months ago

But why is ci not failing?? Anyways fixed it https://github.com/nix-community/nixpkgs-wayland/commit/fc264851354fcf81cc581d31214fbd7920df8958

colemickens commented 5 months ago

I don't know, that's a great question (that I probably won't dig into). Thanks for the fix, didn't realize you already had their cava in the flake. :+1: