search

nix-community / nixvim

Configure Neovim with Nix! [maintainers=@GaetanLepage, @traxys, @mattsturgeon, @khaneliman]
https://nix-community.github.io/nixvim
MIT License
1.71k stars 263 forks source link

Question about the dependencies of coq-nvim #289

Closed GaetanLepage closed 1 year ago

GaetanLepage commented 1 year ago

The coq-nvim plugin has been packaged upstream. However, there, it does not have the python dependencies as the version packaged in nixvim.

Do we need those python dependencies ? More precisely, which one of the following options is the best ?

  1. Those plugins are not mandatory dependencies, it is why they are not part of the upstream vimPlugins.coq_nvim package. We can then remove coq_nvim from the packages that we manually package and rely on the upstream package.
  2. Those dependencies are necessary and it would make sense to upstream them.
  3. In between: it does not really make sense to upstream them, but it is useful to get them for nixvim users.

If option 3, why precisely ?

cc @pta2002 as you packaged this plugin first.

GaetanLepage commented 1 year ago

I made a PR upstream: https://github.com/NixOS/nixpkgs/pull/223056

pta2002 commented 1 year ago

Sorry I could swear I'd replied to this. Thanks for making the PR upstream, it was indeed necessary as otherwise coq would try to download the dependencies by itself and it'd fail as it tried to write to the nix store.

GaetanLepage commented 1 year ago

The upstream PR has finally been merged ! https://github.com/NixOS/nixpkgs/pull/223056 Once the updates makes it to nixos-unstable, coq_nvim user should have a good experience.

Hence, I am closing this issue.