search

nix-community / npmlock2nix

nixify npm based packages [maintainer=@andir]
Apache License 2.0
130 stars 42 forks source link

Use lib.strings.sanitizeDerivationName #132

Closed gilligan closed 2 years ago

gilligan commented 2 years ago

We can use lib.strings.sanitizeDerivationName which does exactly what we want instead of a combination of manually implemented validation and sanitizing functions.

This also adds an integration test with a package that has a name that needs to be sanitized.

gilligan commented 2 years ago

Needs #133 because CI is broken

andir commented 2 years ago

@gilligan please rebase :)

infinisil commented 2 years ago

Now done with #150!