Authentication support - Githubissues

infinisil commented 2 years ago

Implement npm registry authentication, allowing access to private registries via .npmrc

This PR also includes the first two commits from #151 since the same changes are needed for authentication support.

Unfortunately the NixOS VM test for authentication created in this PR can't run in GitHub Actions, but it works locally.

TODO:

[x] Implement .npmrc fields _authToken and _auth
[x] Create a basic test for _authToken
[ ] Implement .npmrc fields _password and username (this might not be possible)
[ ] Test a package-lock.json and .npmrc generated by npm (the current one is hand-written)
[ ] Try to actually run npm with the example from the current test
[ ] Handle environment variables in .npmrc, see https://stackoverflow.com/questions/53099434/using-auth-tokens-in-npmrc
[ ] Improve the code, individual functions should be split off
[ ] More tests, especially for the internal functions used, but also more VM tests for different authentication mechanisms
[ ] Documentation

nixos-discourse commented 2 years ago

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

elmarsto commented 5 months ago

@infinisil Darn it, this is was a feature I kind of needed. What do you recommend instead of this branch?

infinisil commented 5 months ago

@elmarsto Not using npmlock2nix right now unfortunately. Feel free to use my code though for a new PR or fork

nix-community / npmlock2nix