Support for node >15 and npm>7 attempt #2

nix-community / npmlock2nix

nixify npm based packages [maintainer=@andir]

Apache License 2.0

130 stars 42 forks source link

Support for node >15 and npm>7 attempt #2 #165

Closed tlxzilia closed 1 year ago

tlxzilia commented 2 years ago

Should now completely fixes #153.

deemp commented 2 years ago

Hi, @tlxzilia! With

$ which node
/nix/store/6yrgl6gc40938pmax3yd6xabl2mqmk70-nodejs-16.17.0/bin/node

, I get

error: [npmlock2nix] npm lockfile V2 require nodejs version >= 15, it is not supported by nodejs 14.20.0
(use '--show-trace' to show detailed location information)

@andir, could you please check this PR?

tlxzilia commented 2 years ago

@br4ch1st0chr0n3 Did you provide a nodejs attribute in your build/shell attributes? npmlock2nix.build { nodejs = pkgs.nodejs-16_x; }

We might want to bump default version from pkgs.nodejs-14_x to pkgs.nodejs-16_x.

andir commented 1 year ago

I'll close this in favor of #166 as the discussion has moved on there and it is based on this work. Thank you for the work @tlxzilia I really want this to land but as discussed in the other PR there needs to be a tiny bit more of work before I can merge this.