search

nix-community / nur-packages-template

A template for NUR repositories: [maintainer=@fgaz]
MIT License
113 stars 106 forks source link

don't re-import nixpkgs for no reason #89

Open lolbinarycat opened 7 months ago

lolbinarycat commented 7 months ago

instead of import nixpkgs { inherit system; };, which relies on coercing nixpkgs into a string via the outPath attribute the flake system adds, then directly calling default.nix (possibly bypassing customization done by flake.nix), why not just do nixpkgs.legacyPackages."${system}"?

Mic92 commented 7 months ago

where do you see this pattern being used?

Mic92 commented 7 months ago

Ah. here: https://github.com/nix-community/nur-packages-template/blob/756a77175ace2525180e9f169ef6a73cc6fa0baf/flake.nix#L18 Yes. Agreed.