search

nix-community / plasma-manager

Manage KDE Plasma with Home Manager
https://nix-community.github.io/plasma-manager/
MIT License
658 stars 76 forks source link

Lots of refactoring around startup-scripts #355

Closed magnouvean closed 2 months ago

magnouvean commented 2 months ago

Added a runAlways option for startup-scripts and desktop-scripts which is intended to be used for scripts which must run at every login. Also split the wallpapers and panels script into different scripts and not the same as was the case before (even though it wasn't really intuitive). Furthermore, since it's a known problem that running only some of the desktop-scripts may mess up the actions of other desktop-scripts (this was the reason why panels and wallpapers were pushed into a single script in the first place), this PR makes it so that if one of the desktop-scripts need to run (for example due to one of the desktop-scripts having changed contents), all the desktop-scripts will now run together. There's also some increased logging in the autostart script now.

I haven't done extensive testing so some more of that will be needed before merging. When I'll be able to do so I'm not sure, but hopefully not too long. If anyone else has the time to test that would of course be appreciated as always. With that said, from my early tests it seems to look quite good.

HeitorAugustoLN commented 2 months ago

Nice work on the refactor! It is looking better than before.

magnouvean commented 2 months ago

Great! I'll just do a little more testing in one of the coming days and we hopefully can merge somewhat soon.

I think the codebase looks a little better, and is more extensible after this refactoring :)

magnouvean commented 2 months ago

From my testing it now works fine, so I think it should be good to merge.