nix-community / rnix-parser

A Nix parser written in Rust [maintainer=@oberblastmeister]
MIT License
366 stars 44 forks source link

Cleaning up tests #131

Closed darichey closed 2 years ago

darichey commented 2 years ago

I think the tests in the crate could use some improvement. It's not clear what the difference is between test_data/general and test_data/parser, and parser tests are snapshot-based while lexer tests are not

I would like to propose the following:

I am willing to implement the above, but I wanted to get some feedback before starting!

oberblastmeister commented 2 years ago

This is very much needed! I will 100% accept all of these changes.