I think the tests in the crate could use some improvement. It's not clear what the difference is between test_data/general and test_data/parser, and parser tests are snapshot-based while lexer tests are not
I would like to propose the following:
Replace the ad-hoc snapshot testing implementation with expect_test
I think the tests in the crate could use some improvement. It's not clear what the difference is between
test_data/general
andtest_data/parser
, and parser tests are snapshot-based while lexer tests are notI would like to propose the following:
test_data
like so:1.nix
)I am willing to implement the above, but I wanted to get some feedback before starting!