hardware/amazon: redundant `services.cloud-init.enable = true`?

nix-community / srvos

NixOS profiles for servers [maintainer=@numtide]

https://nix-community.github.io/srvos

MIT License

417 stars 16 forks source link

hardware/amazon: redundant `services.cloud-init.enable = true`? #414

Closed bbigras closed 3 weeks ago

bbigras commented 2 months ago

https://github.com/nix-community/srvos/blob/e4252aa777482dc9d4cacd779ae29115de69b7ba/nixos/hardware/amazon/default.nix#L13-L14

Isn't cloud-init already set in cloud-init.nix? https://github.com/nix-community/srvos/blob/e4252aa777482dc9d4cacd779ae29115de69b7ba/nixos/mixins/cloud-init.nix#L3-L4

hbjydev commented 2 months ago

cloud-init isn't exclusive to AWS, hence it having its own mixin separate from the Amazon module. It's available on most cloud providers out there.

I also believe nixpkgs changes that value?

bbigras commented 2 months ago

but amazon/default.nix also imports ../../mixins/cloud-init.nix.

Mic92 commented 3 weeks ago

Yes. Looks like this can be dropped. I think this is just included because we do virtualisation.amazon-init.enable = false; for documentation purpose.