search

nix-community / srvos

NixOS profiles for servers [maintainer=@numtide]
https://nix-community.github.io/srvos
MIT License
417 stars 16 forks source link

Darwin support #441

Closed Mic92 closed 1 week ago

Mic92 commented 3 weeks ago

Now that this seems to be now also part of my own infastructure, I kind of miss having srvos to share configuration. Also there is some opportunity to share code with NixOS, I decided to not do so as it would make contributing to this project harder as not everyone has access to both Linux and MacOS at the same time.

I think it's acceptable to have a slight code drift, but allow to properly test changes on both platforms in their own time.

I still need to update documentation here.

zowoq commented 3 weeks ago

Also there is some opportunity to share code with NixOS, I decided to not do so

I think it's acceptable to have a slight code drift, but allow to properly test changes on both platforms in their own time.

I wanted to share code and avoid drift so this is the opposite of what I wanted to do here.

If this is what you want to do, okay, I'm not interested in debating it but I'm not going to use it for the community infra.

zimbatm commented 3 weeks ago

Sounds good.

To have shared code, we need CI to exercise the Darwin code first. The CI is pretty fast so I think it would be reasonable after that.

Mic92 commented 1 week ago

@mergify queue

mergify[bot] commented 1 week ago

queue

🛑 The pull request has been removed from the queue default

The pull request #441 has been manually updated. You can take a look at `Queue: Embarked in merge queue` check runs for more details. In case of a failure due to a flaky test, you should first retrigger the CI. Then, re-embark the pull request into the merge queue by posting the comment `@mergifyio refresh` on the pull request.