search

nix-community / vgo2nix

Convert go.mod files to nixpkgs buildGoPackage compatible deps.nix files [maintainer=@adisbladis]
MIT License
90 stars 21 forks source link

completely rewriting the application #20

Closed corpix closed 5 years ago

corpix commented 5 years ago

Adding:

Initially I have modified vgo2nix to be able to package fresh bingo(language server protocol agent for go) because it uses git.apache.org/thrift.git and vgo2nix started to ask for a password(because .git was droped and nix-prefetch-git thinked it should use SSH to pull the repo). But this was two months ago. After that I have packaged a lot of other software and have some pain with go pseudo versions. After that I have found internal implementation which go tools use and adopted it(internal packages can not be imported).

Also I have checked today, this fixed https://github.com/adisbladis/vgo2nix/issues/16 UPD: Oops this is because I dropped support for parallel jobs, lol, I'll bring them back soon

corpix commented 5 years ago

To c4609f4e3ee0fd010d80c471f6a67c56c2279ead: test_reporoot/go.mod declares two packages, so I have decided to fix the expected test result.

dingxiangfei2009 commented 5 years ago

@corpix I have tried the rewritten version of yours. The usability of the rewritten vgo2nix is not so good because prefetchModule is a blocking process and dependencies are being downloaded sequentially instead of in parallel.

corpix commented 5 years ago

Oh, yeah, it is not good at parallel fetching at the moment. I think I'll fix this soon

adisbladis commented 5 years ago

I'd like to incorporate some of these changes but a massive rewrite PR is not helpful. Please do smaller incremental pull requests that can be reviewed on their own merit.

corpix commented 5 years ago

Not sure I'll have enough time to do this, but anyway, feel free to incorporate any changes without listing me as contributor