nix-community / vgo2nix

Convert go.mod files to nixpkgs buildGoPackage compatible deps.nix files [maintainer=@adisbladis]
MIT License
90 stars 21 forks source link

Replace truncated commitishes with full ones #29

Open charles-dyfis-net opened 4 years ago

charles-dyfis-net commented 4 years ago

While the nixpkgs fetchgit tool works with truncated commitishes, Nix 2.x's builtins.fetchGit does not.

Moreover, as nixpkgs fetchgit can't handle private repositories when running on a system with nix-daemon used for builds, users may reasonably want to override the fetchgit argument to buildGoPackage and kin with one that switches over to builtins.fetchGit instead.

To support this usage mode, it would be helpful for vgo2nix to replace truncated commitishes with their full text.

(This feature request is added in anticipation of building a PR; any feedback on things to keep in mind during implementation would be appreciated).