Broken on nixos-unstable

[sshiroi]

This overlay is broken on nixos-unstable concerning everything that uses withPlugins:

error: attribute 'withPlugins' missing

       at /nix/store/3i9vpcjk78i7pf6kic3m2bqry2n9lw9h-source/plugins/havsfunc/default.nix:47:20:

           46|
           47|   checkInputs = [ (vapoursynth.withPlugins propagatedBuildInputs) ];
             |                    ^
           48|   checkPhase = ''

I think I managed to track down the commmit that broke it. https://github.com/NixOS/nixpkgs/commit/2c1c79dce66571f97ba5c2a2b1c1175745ec7d79 It seems to me that it's now picking up the python package instead of the acual one that has withPlugins. I don't know how to debug further, since my knowledge around nixpkgs is still sparse.

Repro for nix repl Working:

((import (builtins.fetchTarball { url = "https://github.com/NixOS/nixpkgs/archive/cdb6dc2928e911abc441fc2b3a15a0c7530a913b.tar.gz"; }) { overlays = [ (import (builtins.fetchTarball "https://github.com/tadeokondrak/vs-overlay/archive/master.tar.gz")) ]; }).vapoursynthPlugins.havsfunc)

Broken:

((import (builtins.fetchTarball { url = "https://github.com/NixOS/nixpkgs/archive/2c1c79dce66571f97ba5c2a2b1c1175745ec7d79.tar.gz"; }) { overlays = [ (import (builtins.fetchTarball "https://github.com/tadeokondrak/vs-overlay/archive/master.tar.gz")) ]; }).vapoursynthPlugins.havsfunc)

[sbruder]

Thanks for the report and also sorry for the lack of maintenance on this project, I didn’t really have much time lately.

I also noticed this a few days ago but didn’t add a fix here because I also got stuck on some other problems that probably require an architectural change. Because the fix is independent of that, it can be applied separately from the bigger changes.

I opened #9, which should fix this.

To catch errors like this sooner in the future, I plan on setting up a Hydra instance that builds the overlay against the current nixpkgs version.

[sshiroi]

Thanks for the quick reply. https://github.com/tadeokondrak/vs-overlay/pull/9 Also fixes it on my end. I really appreciate this project. I'll try to contribute some packages that are still missing once i'm more versed in vapoursynth and nix.

[sbruder]

Thanks for confirming this also works for you.

I’ll try doing some maintenance on this project in the next time (mainly updating old packages, but also adding documentation, which currently is virtually nonexistent). If you need any help or think one thing should definitely be documented, don’t hesitate to reach out to me.