search

nix-community / vulnix

Vulnerability (CVE) scanner for Nix/NixOS.
BSD 3-Clause "New" or "Revised" License
476 stars 36 forks source link

Remove duplicate CVEs in output (fixes #25) #27

Closed adisbladis closed 7 years ago

adisbladis commented 7 years ago

This was caused by adding multiple instances of https://github.com/flyingcircusio/vulnix/blob/1.2.2/src/vulnix/nvd.py#L205 to https://github.com/flyingcircusio/vulnix/blob/1.2.2/src/vulnix/nix.py#L110 .

Every Vulnerability instance will be uniquely hashed and therefore the set will have multiple entries, I replaced the Vulnerability instance with a string which always correspond to the same hash.

adisbladis commented 7 years ago

@ckauhaus @plumps Why is this one still pending? Seems like a no-brainer to me.

ckauhaus commented 7 years ago

We are a bit lagging at the moment - so much going on simultaneously. I'll get to reviewing open PRs during the next days. Sorry for the delay!

plumps commented 7 years ago

@adisbladis Sorry, I'm not allowed to commit to master anymore.