search

nix-community / yarn2nix

Generate nix expressions from a yarn.lock file [maintainer=???]
GNU General Public License v3.0
123 stars 61 forks source link

support git dependencies on hydra (fixes #99) #100

Closed ghost closed 5 years ago

globin commented 5 years ago

Should we maybe just use this by default?

ghost commented 5 years ago

Should we maybe just use this by default?

I probably could have documented a bit better why I did it this way. Enabling this will break builds for packages with git dependencies that don't ship yarn.nix, because it requires a network connection to get the hash sum.

Maybe we can make it the default value and pass "--no-hydra" (or similar) when yarn2nix is called at build time to generate yarn.nix on-the-fly.

ghost commented 5 years ago

Should we maybe just use this by default?

I now changed it to use pkgs.fetchgit as default and provide a parameter to use builtin fetchGit, which is always passed when generating yarn.nix on the fly.

ghost commented 5 years ago

@zimbatm can you give a review and possibly merge?

zimbatm commented 5 years ago

thanks!