search

nix-community / yarn2nix

Generate nix expressions from a yarn.lock file [maintainer=???]
GNU General Public License v3.0
123 stars 61 forks source link

Scoped packages fixes #61

Closed nicknovitski closed 6 years ago

nicknovitski commented 6 years ago

Package names like @foo/bar cannot be used for derivation or file names, but should be used to create paths inside of derivations.

nicknovitski commented 6 years ago

it looks like it the error is that there is some @sendgrid/foo module which is installed as a non-workspace dependency, and therefore created as part of modules derivation, so in the package derivation we can't go back and create @sendgrid/helpers.

nicknovitski commented 6 years ago

I'm not too happy with this solution of duplicating the outputs of the modules derivation rather than linking them, so I'm very open to other ideas.

nicknovitski commented 6 years ago

I believe I figured out the answer in #64: converting scope directories from symlinks to directories of symlinks whenever necessary.

zimbatm commented 6 years ago

can you rebase the changes on top of master?

nicknovitski commented 6 years ago

Yep!