search

nix-community / yarn2nix

Generate nix expressions from a yarn.lock file [maintainer=???]
GNU General Public License v3.0
123 stars 61 forks source link

Support git dependencies #85

Closed lheckemann closed 5 years ago

lheckemann commented 5 years ago

This adds support for git dependencies, which allows the generation of working expressions for more javascript projects.

Fixes #1

zimbatm commented 5 years ago

it looks like the nodejs in nixpkgs doesn't understand the async keyword yet. Is it possible to use promises instead?

lheckemann commented 5 years ago

it looks like the nodejs in nixpkgs doesn't understand the async keyword yet. Is it possible to use promises instead?

That's odd, I didn't encounter this… EDIT: It looks like this is the case in 18.03, but not 18.09 or unstable.

zimbatm commented 5 years ago

Oops, I assumed the others were failing in the same way.

error Can't make a request in offline mode ("http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz")

lheckemann commented 5 years ago

Is this using the mkYarnPackage from nixpkgs? It's not compatible with the master branch of yarn2nix.

zimbatm commented 5 years ago

I don't think it is?

zimbatm commented 5 years ago

I don't mean to hold this PR back, if you manage to make the CI go green I will merge happily

srghma commented 5 years ago

I don't understand - which pr is more preferred? this or https://github.com/moretea/yarn2nix/pull/23 ?