nix-community / yarn2nix

Generate nix expressions from a yarn.lock file [maintainer=???]
GNU General Public License v3.0
123 stars 61 forks source link

builtins.fetchGit doesn't work on Hydra #99

Closed ghost closed 5 years ago

ghost commented 5 years ago

Hi everyone, I found the following problem: As long as you add package.json and yarn.nix to nixpkgs, Hydra can use yarn2nix just fine, unless there are git dependencies: https://gist.github.com/GrahamcOfBorg/c37158bafe920d55754e49540461116b

I would suggest to add a mode where git hashes are added when generating yarn.nix and pkgs.fetchgit is used instead of pkgs.fetchGit. Since yarn.nix has to be added to nixpkgs anyways to prevent IFD issues on Hydra, this is only a small inconvenience.