search

nix-rust / nix

Rust friendly bindings to *nix APIs
MIT License
2.57k stars 650 forks source link

Add O_SEARCH to all platforms supported by libc crate #2374

Closed TheJonny closed 2 months ago

TheJonny commented 2 months ago

What does this PR do

Checklist:

SteveLauC commented 2 months ago

Hi, thanks for contributing to Nix, this patch LGTM expect that alias:)

TheJonny commented 2 months ago

Should we also add it in all the other platforms supported by libc that are not in the tier list of nix? that would be aix, wasi, emscripten ?

SteveLauC commented 2 months ago

Should we also add it in all the other platforms supported by libc that are not in the tier list of nix? that would be aix, wasi, emscripten ?

Yeah, I think we can do this

SteveLauC commented 2 months ago

Hi, would you still want to add this symbol for these platforms :)

TheJonny commented 2 months ago

Hi, would you still want to add this symbol for these platforms :)

done - I just was scared by the long cfg line :)

TheJonny commented 2 months ago

(I would also like to see it on apple, but it's currently missing from libc - https://github.com/rust-lang/libc/pull/3659 )