Closed SteveLauC closed 1 month ago
Well, we should only do this for toolchains newer than nightly 2024-05-31, this can be achieved with the help of rustversion.
But I kinda think introducing a new dependency just for this issue is not worthwhile, maybe we should just ignore the lint for this case.
What does this PR do
std::env::remove_var
has been made unsafe. Due to lintunsafe_op_in_unsafe_fn
, we need to wrap it in an unsafe block.This PR is for the following CI failure (full log here):
std::env::remove_var()
will become unsafe ONLY in Rust 2024, Nix is using Rust 2021, so the above issue should not happen. I have filed an issue for this bug, before it gets fixed, ignore the lintunsafe_op_in_unsafe_fn
here.Checklist:
CONTRIBUTING.md