Shouldn't set `#[deny(warnings)]` outside of CI

nix-rust / nix

Rust friendly bindings to *nix APIs

MIT License

2.63k stars 661 forks source link

Closed tbu- closed 3 months ago

tbu- commented 4 months ago

It's brittle against new compiler versions (they might introduce new warnings) and also concretely stopped crater from finding a regression in a Rust change: https://github.com/rust-lang/rust/issues/125875#issuecomment-2145170177.

asomers commented 4 months ago

Yes, good point. We should switch to using -Dwarnings in CI instead.