Fix the build with -Zdirect-minimal-versions

nix-rust / nix

Rust friendly bindings to *nix APIs

MIT License

2.63k stars 661 forks source link

Fix the build with -Zdirect-minimal-versions #2453

Closed asomers closed 3 months ago

asomers commented 3 months ago

The difference between -Zminimal-versions and -Zdirect-minimal-versions is subtle. But the important point is that with the former, a new release published by one of our dependencies can cause our CI to fail. With the latter, it cannot. That's why I think it's better to test with the latter.

SteveLauC commented 3 months ago

a new release published by one of our dependencies can cause our CI to fail.

So I guess that's one of the reasons why this flag is not recommended for usage:)