nix-rust / nix

Rust friendly bindings to *nix APIs
MIT License
2.68k stars 668 forks source link

refactor: make test_parsing_kernel_version() private #2501

Closed SteveLauC closed 2 months ago

SteveLauC commented 2 months ago

What does this PR do

The test function test_parsing_kernel_version() is public, which is unnecessary since it is under attribute #[test]. Also, it causes the CI failure in PR #2500:

error: missing documentation for a function
   --> src/features.rs:95:5
    |
95  |     pub fn test_parsing_kernel_version() {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: the lint level is defined here
   --> src/lib.rs:121:12
    |
121 |     #[deny(missing_docs)]
    |            ^^^^^^^^^^^^

error: could not compile `nix` (lib test) due to 1 previous error

so let's make it private.

Checklist: