Thanks!

[bindzus]

Dear Tôn,

This looks great, I can't wait to review your submission, but before I do so please notice that you have to use the README template provided in the pre-work assignment:

https://gist.githubusercontent.com/harley/40f60111c35a7bc04123/raw/67f2e2486068cd894423a8956a24fd9c3f2c281f/README.md

Once you have updated this file, then I will be able to complete the review of your submission.

Kind regards

• Thomas

[bindzus]

I forgot to mention that according to Step 4 you have to submit your app to Heroku as well ;-)

[nix010]

Hi Thomas

Sorry for some missing in my commit but last time I didn't see those requirements,

And me and my friend are thinking of doing a mini e-com site with rails so can we remake this assignment for with each other ? ( we've made a few cool features too :D )

Thanks Khiem

2016-10-01 11:18 GMT+07:00 Thomas Bindzus notifications@github.com:

I forgot to mention that according to Step 4 you have to submit your app to Heroku as well ;-)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gearazk/rail-pre-work/issues/1#issuecomment-250891441, or mute the thread https://github.com/notifications/unsubscribe-auth/APrTvGu1aQqExNiTnVaMCnmp_dyrFnxdks5qvd8JgaJpZM4KLqc3 .

[bindzus]

This is the assignment: https://quip.com/swTNAN8UZrTI

You cannot implement and submit anything else than these requirements. If your friend also wants to apply for the Ruby class this October, then he should submit an application as well.

[nix010]

Hi Thomas

Actually we both already submit out assignment and we want to make some thing a bit more with rails.

I've updated my asignment according to the requirements :D so you could review my project now. If there're any problems with it, please let me know, Thanks

[nix010]

And I have a question that my project on heroku can't do "DELETE" post, on local it work just fine !! Can you give me a solution for this ?

Thanks

[hoangtan223]

@gearazk about "DELETE" feature on heroku, you can try to add the tether gem and add //=require tether in application.js, It is a bug of Bootstrap 4 beta on Rails

[coderschoolreview]

Hi Tôn, great job updating the repository and your page looks neat, however the delete problem is still not fixed, you have to include the following lines in your Gemfile:

source 'https://rails-assets.org' do
  gem 'rails-assets-tether', '>= 1.1.0'
end

And as Tân writes above, you must also add //=require tether from your applications.js.

--

• Thomas

[coderschoolreview]

Notice also that your article model's name is spelled wrong you are missing a dot at the end of the first where call, else the second where call will return disregarding the first condition. Having said that it would be better to use something like where('(title ILIKE ? or body ILIKE ?)', title: search, body: search).
--
Thomas

[nix010]

Hi Thomas,

I've done what you said but my project in heroku still can't "delete". Can you tell me why ? And I updated the search query :D thanks for notice

[coderschoolreview]

Sorry for the late reply, I think I know what's wrong, I will take a look and let you know. As far as I can see it's only a minor issue and you should be able to join the class on Monday.

[coderschoolreview]

@gearazk the problem is the order in which you include the JavaScript libraries, please remember to follow the README files, sometimes the order of inclusion is important. In your JavaScript file application.js the order should be:

//= require jquery
//= require tether
//= require bootstrap-sprockets
//= require jquery_ujs
//= require turbolinks
//= require_tree .

I would remove the //= require_tree . statement because it includes all JavaScript files in the folder and I like to know exactly what I include.

You can see the result here

Thomas

[nix010]

Thanks :dancing_men: I got it, Glad to join the class