search

nixcloud / ip2unix

Turn IP sockets into Unix domain sockets
GNU Lesser General Public License v3.0
361 stars 10 forks source link

Build fixups for version 2.1.2 #12

Closed aszlig closed 4 years ago

aszlig commented 4 years ago

Version 2.1.2 has introduced a few issues (eg. #10, #11) which particularly surface on non-NixOS systems. This branch should essentially fix building the library/executable as position-independent code and also fix our linker script.

All those issues were introduced with 8e10ef2d1d76ba8835735eaab167e77de34df88a.

Hydra jobset: https://headcounter.org/hydra/jobset/ip2unix/build-fixups Cc: @etam

aszlig commented 4 years ago

@etam: Can you please check whether ip2unix works with these fixes?

etam commented 4 years ago

:+1:

aszlig commented 4 years ago

+1

I hope this means that it's working. :-)

Added another fix (and regression test) for the linker script which was actually being passed to cflags instead of ldflags and thus not working. Can you please check whether the fix works for you as well?

etam commented 4 years ago

Yes it works. I had one unrelated spurious SIGSEGV in test_globpath. See #15.