search

nixcloud / ip2unix

Turn IP sockets into Unix domain sockets
GNU Lesser General Public License v3.0
357 stars 10 forks source link

Fix header includes. #32

Closed vamega closed 1 year ago

vamega commented 1 year ago

In https://github.com/nixcloud/ip2unix/issues/31 it was suggested that cleaning up the imports was something worth doing.

This includes the fixes for #30 and #31, and I think cleans up other imports as well.

The changes come from running the include-what-you-use tools, and then manually editing changes that were suggested.

I do have nix dev-shell set up in my import-fix-wip branch. Using include-what-you-use as nix tool seems to be broken. The dev-shell is based on work on the branch by @Et73f that I found when reading https://github.com/NixOS/nixpkgs/issues/189753

The devShell isn't part of this CR

aszlig commented 1 year ago

@vamega: Did you run iwyu manually or as part of the Meson build process? I'm asking since the preferred way would be to run this via CI and thus quickly find new issues as soon as they're introduced.

Ah, never mind... just saw your branch and might give it a shot to integrate later.

vamega commented 1 year ago

I wasn't able to find a way to run it via meson. I used the generated compile-commands.json, with iwyu-tool.py.

Hopefully the history of modifications in the import-fix-wip branch are helpful.