nixgates / plugin.video.seren

Repository for Seren Development
306 stars 95 forks source link

[REQUEST] Setting to ignore Dolby Vision. #533

Closed Minefield247 closed 2 years ago

Minefield247 commented 3 years ago

I was wandering if it would be possible to add a setting to allow users to ignore Dolby Vision encoded files (they appear to have DV in the title). There appears to be no fallback so if you don't have DV compatible gear you just get the audio. For test purposes most/all of the WanderVision series has DV files. Thanks for the awesome add-on.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

drinfernoo commented 3 years ago

Commenting to keep open.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been closed automatically due to inactivity. Please feel free to re-open this issue if it's in error

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

CalmConcept commented 2 years ago

I’ve currently added the following lines to my source_utils.py file under the Undesirable Items filter which seems to do the trick:

" dv ", "dovi", "dolby vision", "dolbyvision"

It would be nice if we could get this feature implemented natively in Seren as we currently have to re-add these filters after each update.

Liquidrag commented 2 years ago

I’ve currently added the following lines to my source_utils.py file under the Undesirable Items filter which seems to do the trick:

" dv ", "dovi", "dolby vision", "dolbyvision"

It would be nice if we could get this feature implemented natively in Seren as we currently have to re-add these filters after each update.

Where can the source_utils.py be found and what line do you add it to?

CalmConcept commented 2 years ago

Where can the source_utils.py be found and what line do you add it to?

I'm running my setup on Mac and wasn't sure were to find the source_utils.py file. I got around it by using the official Kodi Backup add on and then navigating to the backup folder > addons > plugin.video.seren > resources > lib > common > source_utils.py. I then added the code as per the image below. Screenshot 2021-12-10 at 10 41 11 AM

Then I used the Backup add on to restore that backup :)

Dealz-416LS commented 2 years ago

Where can the source_utils.py be found and what line do you add it to?

I'm running my setup on Mac and wasn't sure were to find the source_utils.py file. I got around it by using the official Kodi Backup add on and then navigating to the backup folder > addons > plugin.video.seren > resources > lib > common > source_utils.py. I then added the code as per the image below. Screenshot 2021-12-10 at 10 41 11 AM

Then I used the Backup add on to restore that backup :)

I tried this, but wasn't able to get it to work.

CalmConcept commented 2 years ago

I tried this, but wasn't able to get it to work.

Ah sorry to hear that. Have you rebooted Kodi after the backup restoration?

It’s quite an involved work around and works on my side but would be great if we could get a simple toggle. I know Fen has one but I personally prefer using Seren.

Edit: I think there was also a second section in the code referencing ‘cam’ qualities which I added the DV references to as well. So just look out for that 👌

Liquidrag commented 2 years ago

Where can the source_utils.py be found and what line do you add it to?

I'm running my setup on Mac and wasn't sure were to find the source_utils.py file. I got around it by using the official Kodi Backup add on and then navigating to the backup folder > addons > plugin.video.seren > resources > lib > common > source_utils.py. I then added the code as per the image below. Screenshot 2021-12-10 at 10 41 11 AM

Then I used the Backup add on to restore that backup :)

Thank you. On a mac, if you click finder then at the top menu, click "go" then hold "option" on the keyboard, "library" should show up. from there Kodi can be found under Application Support

CalmConcept commented 2 years ago

Thank you. On a mac, if you click finder then at the top menu, click "go" then hold "option" on the keyboard, "library" should show up. from there Kodi can be found under Application Support

Awesome thanks! That’ll make my life easier when the next update comes around.

drinfernoo commented 2 years ago

For a bit more information, the changes you guys are making actually seem to be exploiting a bug in the current version of Seren, in which all "cam" copies are getting filtered, regardless of any other information about them... You're basically telling Kodi that DV copies are cams.

In a future version there will be a setting for ignoring DV copies, and also the bug I mentioned will be fixed, allowing for cams to be properly filtered.

tundrablasen commented 2 years ago

A gesture that ignores Dolby vision is really good. Most of the big files are nowadays DV and picked first. But my tv does not support it so no video for me. That means no autoplay

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Dealz-416LS commented 2 years ago

Not stale, active feature request.

tundrablasen commented 2 years ago

Can this be please included in the normal settings? Thanks

CalmConcept commented 2 years ago

Can this be please included in the normal settings? Thanks

Yeah I’m still running into issues having to manually select sources else watch Moon Knight with sound only lol

sinanawad commented 2 years ago

Pretty please 😊

Liquidrag commented 2 years ago

Can this be please included in the normal settings? Thanks

Yeah I’m still running into issues having to manually select sources else watch Moon Knight with sound only lol

I’m still using your exploit. I don’t watch cams so I can live without them and DV until we get an update. I sure hope Nix is ok.

whambulancePilot commented 2 years ago

I’m still using your exploit. I don’t watch cams so I can live without them and DV until we get an update. I sure hope Nix is ok.

to Liquidrag and others:

Make sure you add those DV strings to the CAM strings [HERE] in the get_info function instead of the def get_quality function.

There's no need to use the "exploit" by entering them in the wrong function. Just enter them where they are supposed to be and enable the Undesirables filter. That "exploit" was just a separate long withstanding bug with Seren.

drinfernoo commented 2 years ago

We have this mostly implemented in development, so it should be available whenever Seren gets another update :+1:

Liquidrag commented 2 years ago

@drinfernoo glad to hear development is still moving forward. It’s been a minute since the last update and I feared something had gone awry health wise. I look forward to the next update. Many thanks to everyone involved to keeping Seren going.

drinfernoo commented 2 years ago

This is now implemented in 2.2.0, by way of new filtering settings 👍

CalmConcept commented 2 years ago

@drinfernoo Yes, I saw this yesterday! Thanks guys🖤 this is such a help

Liquidrag commented 2 years ago

👍

Thank you guys for the update! It’s flying 👍🏼👍🏼