search

nixgates / plugin.video.seren

Repository for Seren Development
306 stars 95 forks source link

[BUG] Next Up not working 100% #872

Closed TapMeDead closed 1 year ago

TapMeDead commented 1 year ago

Small bug in the Next Up system. Sometimes it doesn't work as intended. Not all the time, but from the "Next Up" section, I just started an episode, and at the end of it, it did not pop up with Next Up, nor did pressing >> (next) on the player keys make it go to next episode. I copied this log file right after this happened this time, seen it one or two times before but didn't think anything of it, but now it's an upwards trend on it happening I think. The next episode does have sources and everything, just started that one manually. Kodi V 19.4 Seren 3.0.0 Windows 10

https://logpaste.com/r9a4IIwF

TapMeDead commented 1 year ago

Some random thoughts, did I see the a4k scrapers being updated today at some point? could this be a factor? Also, I upgraded the a4k scraper a few days ago, but did not delete the old a4k in there, should I do that or not? Screenshot_1

cgwprs commented 1 year ago

I could see having two versions of the a4kscraper causing issues with Seren because of the way it scrapes different domains changes over time. I don't know that this would cause any issue with Next Up, but I will look into it, to see if I can contribute.

TapMeDead commented 1 year ago

Update, I watched 4 more episodes via the Next Up section, and none of them activated Next Up to go to next episode on the list from there. The new log: https://logpaste.com/4DMv3OcT

drinfernoo commented 1 year ago

@TapMeDead You are watching shows that have more episodes available, right? Not ones that have just come out and have no further episodes to watch yet?

TapMeDead commented 1 year ago

@drinfernoo Watching through the Next Up section where new episodes come up every day. So yes and no heh, but usually Seren will create a playlist off of the Next Up page, it just didn't today, and a few times yesterday.

drinfernoo commented 1 year ago

What I mean is, the shows you are choosing from Next Up, are they shows with more episodes for you to watch (i.e. shows that are finished and you're "catching up on"), or shows that have no new episodes after the current (i.e. "continuing" shows which you are caught up on)?

If they have no more aired episodes available, then no playlist will be built.

TapMeDead commented 1 year ago

@drinfernoo It has always, for as long as I've used Seren worked to, as you say it, catch up on recently aired episodes, through the Next Up window in shows. It would just cache the next episode, from the next show on that list. I always thought the cool thing about the Next Up system, was that it creates a list out of the current window, be in Next Up, or in a season window. All I know is, it doesn't work as it has just a few days ago heh

drinfernoo commented 1 year ago

Can you give an example of content that does have future episodes to build a playlist with, that doesn't end up showing you the Playing Next dialog?

I'm having trouble discerning in which situation you're saying it's not building playlists.

TapMeDead commented 1 year ago

@drinfernoo That would be the first two log files upthere :) In the Next Up window, all my shows that have aired episodes today will collect, right. If I click the first episode up top, it will find sources for it, and start playing. Then once that episode is over, usually the Play Next popup will come up, and will want to play the next item from my Next Up window. This does not always happen anymore, the Play Next popup does not come up, and nothing is cached as intended. My log files should be old enough that you can see how it usually behaves, and compare to today :)

TapMeDead commented 1 year ago

I can how ever confirm that it seems to work as usual if I am in a season window binge watching. Play Next pops up as intended here right now.

drinfernoo commented 1 year ago

For now, I'm unable to reproduce this.

Steps I took to attempt to reproduce:

  1. Ensure that both "Enable Smart Play" and "Enable Playing Next Dialog" are checked in the "Playback" section of Seren's settings
  2. Search for show in Seren (I tested with Steven Universe, which has episodes ~11min long)
  3. Pick an episode early on the series (I chose S01E01 to start)
  4. Watch or skip to near the end (with <= 30 seconds remaining by default)
  5. See the "Playing Next" dialog pop up, displaying the next episode in the playlist

You can also check throughout this process whether or not the playlist has been built by viewing the items in your playlist during playback.

In contrast, I chose the last episode of the series (S05E28) as another test, and as there are no further episodes after it, the dialog does not show up.

drinfernoo commented 1 year ago

Some random thoughts, did I see the a4k scrapers being updated today at some point? could this be a factor? Also, I upgraded the a4k scraper a few days ago, but did not delete the old a4k in there, should I do that or not? Screenshot_1

This seems inconsequential. You have two different provider packages installed, not two versions of the same one. In any case, providers should not affect the building of playlists or the dialogs shown during playback.

drinfernoo commented 1 year ago

As an example, in your log:

2022-12-30 13:39:57.823 T:18976 INFO <general>: SEREN (6): Seren, Running Path - {'action': 'getSources', 'action_args': {'mediatype': 'episode', 'trakt_id': 6789853, 'trakt_season_id': 304422, 'trakt_show_id': 153528}}

This is The Mosquito Coast S02E09. As of the time of this issue, that is the latest episode (https://trakt.tv/shows/the-mosquito-coast/seasons/2/episodes/9), having aired 12/29/22, so there will be no future episodes with which to build a playlist.

I've also found Mythic Quest S03E09, Echo 3 S01E08 and Slow Horses S02E06.

All of these are the latest episodes at this time. The dialog should not be shown if there are no future episodes available. This is working as intended.

TapMeDead commented 1 year ago

@drinfernoo I mean you closed this with "invalid"? lol man... You are wrong, and I have to ask, do you actually use Seren to watch your episodes from Next Up? Because then you would know that for as long back as I recall, if you started an episode In the Next Up window, the Play Next would create a playlist out of the Next Up list, and Play Next would work just fine, starting the next episode of the next show on the Next Up list. This stopped working in 3.0.0, and now we have to manually close video, pick next show in Next Up and this gets tedious pretty fast when we watch a lot of shows in this window.. Ask Nix about this before you answer me again please, I know I had some lingo confused explaining this, but its a bug when something stops working as it has for year(s) :) Screenshot_3

Screenshot_4

cgwprs commented 1 year ago

This issue is still confusing me. Is Seren using the no longer maintained addon-on "Next Up" embedded into Seren? I thought that maybe it was embedding "Up Next" (currently maintained fork of Next Up) but that community thinks Seren has its own code for the "Next Up" feature. It seems quite odd that I am getting the same issue in two separate add-ons. Even adding the current version of Up Next to Kodi directly, does not fix the problem. Now I feel like I need to actually look at the code.

TapMeDead commented 1 year ago

This issue is still confusing me. Is Seren using the no longer maintained addon-on "Next Up" embedded into Seren? I thought that maybe it was embedding "Up Next" (currently maintained fork of Next Up) but that community thinks Seren has its own code for the "Next Up" feature. It seems quite odd that I am getting the same issue in two separate add-ons. Even adding the current version of Up Next to Kodi directly, does not fix the problem. Now I feel like I need to actually look at the code.

I don't know about which version of what, all I know is, if I watch my newly aired shows from the next Up window, the popup, and the caching of sources in the background, does not work as intended, and only in the Next Up window, Play Next works fine if I am in a season window with several episodes.