search

nixified-ai / flake

A Nix flake for many AI projects
GNU Affero General Public License v3.0
624 stars 69 forks source link

How much of this do you think we can get upstreamed? #48

Open Madouura opened 8 months ago

Madouura commented 8 months ago

Hi there, was just curious if we could get most/all of this upstreamed to nixpkgs. Haven't had a thorough look around yet, but at least a bunch of the python packages should be able to be upstreamed. Also you might want to make sure things are working for ROCm 5.7.0. https://github.com/NixOS/nixpkgs/pull/258328 upgraded the ROCm stack.

MatthewCroughan commented 8 months ago

I have wanted to merge the overlays into Nixpkgs for quite some time now, but I lack the manpower, and I'm only one guy. I welcome it!

MatthewCroughan commented 8 months ago

I think there is a good flow I could get into, which is to upstream the drvs to nixpkgs in the first place, and wait for them to be merged, since we don't buy any time by holding the overlays ourselves, since updating them is also a maintenance burden.

Madouura commented 8 months ago

For the stuff I do upstream from here, do you mind if I add you to the maintainers?

MatthewCroughan commented 8 months ago

@Madouura absolutely, and in fact can you please make a PR to remove it from here when you do? Or perhaps I can do that lazily as stuff gets into Nixpkgs, in one big PR.

haras-unicorn commented 8 months ago

@Madouura did u try doing this already? id like to contribute if i can! if not ill make a draft pr by adding the python packages one by one and link the pr here i think it would be easier to do it all in one big pr if nixpkgs maintainers are ok with that

Madouura commented 8 months ago

Currently side-tracked with another issue I'm trying to crack. If you have the time by all means go ahead, I'll try to review what I can.

haras-unicorn commented 8 months ago

alrighty then - mind u this would be my first nixpkgs contribution but hopefully i get some things right! heres the pr - only added a single python package for now but will add more and a checklist of all things to do to get it merged ill let u know when its ready for review or if i need assistance/guidance

MatthewCroughan commented 8 months ago

@haras-unicorn that's incredible, thank you so much, I hope Nixpkgs accepts it.

haras-unicorn commented 8 months ago

im kinda stuck on the dependency sets thing - any idea how to properly put that into inxpkgs?

MatthewCroughan commented 8 months ago

What is the dependency sets thing? I don't know exactly what you mean, happy to help if I can though!

haras-unicorn commented 8 months ago

ok looking at the code in the module folder the dependency-sets thing creates the dependency sets option and then the aipython3 module adds the "dependency sets" (all the packages we need through multiple overlays) through that which is then consumed in the koboldai and invokeai projects i am just really unsure of how to add all this to nixpkgs since this is my first time contributing ill ask some more on the nixos discord