search

nixin72 / from-template

Raco tool for cloning templates from the racket-templates org
MIT License
8 stars 4 forks source link

Add macosx support #4

Closed spdegabrielle closed 4 years ago

spdegabrielle commented 4 years ago

@nixin72 @soapdog seems to work

@nixin72 can you update https://pkgd.racket-lang.org/pkgn/package/from-template ?

I'd like to do a 'beta' release on racket slack, because something always comes up.

nixin72 commented 4 years ago

The bash script for MacOS is the same as the one for Linux - how come you'd like to add a script specifically for mac?

spdegabrielle commented 4 years ago

Oops - added I’m error- let me fix

spdegabrielle commented 4 years ago

@nixin72 the macOS version is correct - it differs by one line;

    git clone "https://github.com/racket-templates/$1.git" $2
spdegabrielle commented 4 years ago

Uses https

nixin72 commented 4 years ago

Hmm, I think they should both use HTTPS actually. Cause the SSH one will rely on the user having an SSH key set up. But the two should be the same I think. I'll change the Linux one to use HTTPS instead of SSH.

spdegabrielle commented 4 years ago

in hindsight I'm surprised the linux version doesn't need the define-runtime-path

The good think about a beta on slack is it will shake little things like this out.

spdegabrielle commented 4 years ago

@nixin72 is there any barrier to applying this PR? (you may want to 'squash')

soapdog commented 4 years ago

Should I alter the windows version to use HTTPS as well?

spdegabrielle commented 4 years ago

Thank you @nixin72 Philip!