andoresuperesu commented 6 years ago

2 conditional could be added to check if asciidoc (python 2 exclusively) or asciidoctor (ruby/python version agnostic) is installed; however asciidoctor is the current asciidoc implementation as stated in here. Please let me know if anything additional can be done.

I'd call this a new version. What do you think?

nixjdm commented 6 years ago

This looks good to me. I'd like to test this first before pulling in the next day or two. Alternatively, if you could whip up a test, I wouldn't feel the need to manually test it. If I end up pulling without a written test I'll make an issue for it. Thanks for the patience.

andoresuperesu commented 6 years ago

Woohoo! Thanks man, I'll read about tests and try to write one. Plus I really don't know how to install a plugin under development, so I installed the regular version and then modified the script directly. I think I'll do the same with tests, although I verified with existing tests and it runs perfectly.

andoresuperesu commented 6 years ago

@nixjdm This is over my head, I have no clue how to even start with the tests.

nixjdm commented 6 years ago

Alright, thanks for the effort :) I'll test it manually and pull it if it works.

If I find extra time I'll expand the tests myself if you don't keep fighting it and beat me too it. If you want to talk more about testing / plugin development, jump on the gitter channel sometime and ping me. If it's soonish I'll probably be on and can help you out.

andoresuperesu commented 6 years ago

@nixjdm I'll try my best, believe me I didn't earn anything giving up, it is more a retreat and regroup thing. I talked to a local developer with testing experience, but it seems more complex than expected at first sight. I'll write through gitter. Once again THANKS!

nixjdm commented 6 years ago

@andresperezcera I've been thinking. It seems like it would probably be a better idea to leave this repository be, keeping Python 2's asciidoc, and instead make a fork of it for asciidoctor as it's own thing. That continues supporting Python's asciidoc for as long as it exists. To do this I'd make a branch and merge this PR into it, fork that, and then publish a new plugin. I don't need to wait on a test for that either. We'll just add the test to the new plugin when we have it. Sound good @andresperezcera?

Along with this, I'll make some changes to the Readme pointing to the new plugin unless they really want this one.

andoresuperesu commented 6 years ago

@nixjdm that puts us on the same page. Should I publish a new plugin based on this one or will you do it? The new one should be called lektor-asciidoctor, what do you think?

nixjdm commented 6 years ago

Either way is fine with me. If you want to fork it and own it yourself, it will be a good experience for you, and take just a little bit off my plate ;) But I can also add it to the list of ten-ish lektor repos I maintain. No problem either way.

andoresuperesu commented 6 years ago

@nixjdm I'll register it myself because it's true it will be a good experience. I'll rename the current repo. Could you reject the fork based on this thread? I'll update documents to instruct others in reference to Ruby and asciidoctor.

nixjdm commented 6 years ago

You got it! When you're done, please also send a pull request to https://github.com/lektor/lektor-website to add the new plugin to the list. And if you want to see a more full featured setup.py, readme, and such, I just updated https://github.com/terminal-labs/lektor-jinja-content, so it's got about everything I can think of in it.

nixjdm / lektor-asciidoc

Modification for python 3, updated to asciidoctor. #4

2 conditional could be added to check if asciidoc (python 2 exclusively) or asciidoctor (ruby/python version agnostic) is installed; however asciidoctor is the current asciidoc implementation as stated in here. Please let me know if anything additional can be done.