nixon-voxell / UnityNLP

Natural Language Processing in Unity.
https://unitynlp.readthedocs.io/
Apache License 2.0
62 stars 6 forks source link

Missing namespaces #7

Closed Wholebitmedia closed 2 years ago

Wholebitmedia commented 2 years ago

I successfully cloned all the necessary repositories from GitHub desktop into unity but there were a lot of missing namespaces. Is there another repository besides the UnityAI,NLP,Util, and the models package that needs to be cloned? This repository makes reference to a Cherub and well as another referenced NLP resource. Any help would be appreciated.

Using WIn11 Unity 2019.4

nixon-voxell commented 2 years ago

hey there, a screenshot or a copy of the errors of missing namespaces would be great for me to debug!

nixon-voxell commented 2 years ago

References are purely references in terms of looking at their code or copy and pasting in. There are no dependencies towards those repositories/code.

Wholebitmedia commented 2 years ago

Oh yeah, sorry lemme get that. About 42 in all.

On Thu, Jul 21, 2022 at 1:32 AM Nixon @.***> wrote:

References are purely references in terms of looking at their code or copy and pasting in. There are no dependencies towards those repositories/code.

— Reply to this email directly, view it on GitHub https://github.com/voxell-tech/UnityNLP/issues/7#issuecomment-1191094961, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOGIM2Y5XXLQRSS3EFT7E3LVVDVIHANCNFSM54GMCJSQ . You are receiving this because you authored the thread.Message ID: @.***>

Wholebitmedia commented 2 years ago

Installed fresh one with lot fewer problems. Usually when I fix somethingng a few more pop up but here is the screenshot. Incidentally before I dive into weeks of research what has been your experience/opinion of the LUIS and/or Catalyst models for C#?

[image: image.png]

On Thu, Jul 21, 2022 at 10:07 AM Terry Daniels @.***> wrote:

Oh yeah, sorry lemme get that. About 42 in all.

On Thu, Jul 21, 2022 at 1:32 AM Nixon @.***> wrote:

References are purely references in terms of looking at their code or copy and pasting in. There are no dependencies towards those repositories/code.

— Reply to this email directly, view it on GitHub https://github.com/voxell-tech/UnityNLP/issues/7#issuecomment-1191094961, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOGIM2Y5XXLQRSS3EFT7E3LVVDVIHANCNFSM54GMCJSQ . You are receiving this because you authored the thread.Message ID: @.***>

nixon-voxell commented 2 years ago

Hey I don't think I can see the image here. You might want to comment on GitHub instead of via email xd.

Wholebitmedia commented 2 years ago

Here it is. What if any is your opinion of those models? image

nixon-voxell commented 2 years ago

Ah I see. It's a very minor bug haha. So basically I update UnityUtil frequently and sometimes I break things xd. Will update the package ASAP to fix this up.

Wholebitmedia commented 2 years ago

OK Keep me posted...

On Thu, Jul 21, 2022 at 11:14 AM Nixon @.***> wrote:

Ah I see. It's a very minor bug haha. So basically I updated my UnityUtil frequently and sometimes I break things xd. Will update the package ASAP to fix this up.

— Reply to this email directly, view it on GitHub https://github.com/voxell-tech/UnityNLP/issues/7#issuecomment-1191739775, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOGIM2ZUSXYMV5TQSVQIDH3VVGANTANCNFSM54GMCJSQ . You are receiving this because you authored the thread.Message ID: @.***>

nixon-voxell commented 2 years ago

As for the models I'm not so sure tho. I have not personally used all of the models yet. And the ones you mentioned are among those.

nixon-voxell commented 2 years ago

hey man, just opened up Unity in 2021 and found no issue, those error above are errors about missing stuff from Unity not from my packages. I am not sure why your 2020 doesn't have those.. try upgrading Unity to latest LTS and load the project again.

Wholebitmedia commented 2 years ago

Opened in 2022 and everything was installed and error free, then I imported the NLP examples and this happened.
image

nixon-voxell commented 2 years ago

ok I might need to update the samples

nixon-voxell commented 2 years ago

hmm.. not sure why, it works for me though, just to be safe, make sure to use the develop branch and also pull the latest changes image

Wholebitmedia commented 2 years ago

Working form 2020.3.22 now after downloading the develop versions and installing from disk.(github link didn't work) Also Util and NLP will not import until after the models are imported. Getting 4 console errors:

UnityNLP-develop\UnityNLP-develop\Runtime\VoxellNLP\Coreference\Mention\DictionaryFactory.cs(56,24): error CS0103: The name 'ConfigurationManager' does not exist in the current context

UnityUtil-develop\UnityUtil-develop\Editor\EditorList\EditorListUtil.cs(26,12): error CS1061: 'ReorderableList' does not contain a definition for 'multiSelect' and no accessible extension method 'multiSelect' accepting a first argument of type 'ReorderableList' could be found (are you missing a using directive or an assembly reference?)

UnityUtil-develop\UnityUtil-develop\Editor\EditorBase\VXDefaultEditor.cs(54,11): error CS0246: The type or namespace name 'PrefabStage' could not be found (are you missing a using directive or an assembly reference?)

UnityUtil-develop\UnityUtil-develop\Editor\EditorBase\VXDefaultEditor.cs(54,31): error CS0103: The name 'PrefabStageUtility' does not exist in the current context

nixon-voxell commented 2 years ago

please use 2021 or higher thanks

Wholebitmedia commented 2 years ago

Using the latest version 2022.2 achieved one error, looked it up deleted the Library folder, still there 📦

error CS0006: Metadata file 'System.Configuration.dll' could not be found

nixon-voxell commented 2 years ago

ah this prob, I don't know why some comp works and some don't, I suspect that you will need to have the dll downloaded in your machine via the nuget package manager on visual studio, but I might be wrong..

fyi, I included it via a simple script here instead of the actual dll: https://github.com/voxell-tech/UnityNLP/blob/master/Runtime/VoxellNLP/csc.rsp

Wholebitmedia commented 2 years ago

Should I put that csc.rsp file in my Library folder somewhere? Did that same error. If possible could you upload a zip of that test you made for comparison?

Rafhly commented 2 years ago

This worked for me. -Created a new project with the 2021.3.6f1 version of unity -Changed scripting Backend to IL2CPP -Changed api compatibility to .NET Framework

I then just proceeded to import all the packages. I also encountered problems with system.configuration but this did the trick. (if your system.configuration is still missing, have you tried adding it as reference?)

However in the end I still end up with several warnings.

nixon-voxell commented 2 years ago

Hey @Rafhly thanks so much! Yeah that might be it, the IL2CPP and .Net thingi.

What warnings did you encounter tho? Would like to know about them.

Wholebitmedia commented 2 years ago

Thanks @Rafhly! Changed scripting and compatibility and no errors but this warning:

Assembly for Assembly Definition File 'Packages/voxell.ai/Runtime/VX.AI.Runtime.asmdef' will not be compiled, because it has no scripts associated with it. UnityEditor.Scripting.ScriptCompilation.EditorCompilationInterface:CompileScripts (UnityEditor.Scripting.ScriptCompilation.EditorScriptCompilationOptions,UnityEditor.BuildTargetGroup,UnityEditor.BuildTarget,int,string[])

Anyway, the example scene is working great!

nixon-voxell commented 2 years ago

@Wholebitmedia great to hear about that! oh yeah the warning can be safely ignored, it's just missing scripts in a folder that contains an assembly definition. Will take a look at what I can do with it, either remove it or start adding scripts.

Rafhly commented 2 years ago

@Wholebitmedia Glad it worked! and yes those were the warning signs @nixon-voxell haha but good to know that they can be safely ignored. Thanks!

Wholebitmedia commented 2 years ago

Asking about the json data for the trainer. I have several sentences in my data that are in this format: "I/they/it/when you" will it not work unless I break up into: I when you....They when you etc. Or will not work unless it is complete? Should I leave spaces in between slashes? I want it to recognize/classify when these two segments (pronoun + adverb) are in the same sentence in this order. Is the classifier "wholistic" so to speak?

nixon-voxell commented 2 years ago

I think you will need to break them up. But you can always just modify the source code to make it work the way you want, or just make a custom text post processing to break them up before it is being passed to the "trainer". Btw do join the discord server for questions like this xd.