nixops4 / nixops4

Deploy with Nix and manage resources declaratively
272 stars 9 forks source link

Document the relationship between `EvalState` and `Store` #28

Open Radvendii opened 5 months ago

Radvendii commented 5 months ago

Our EvalState has an associated Store, and it's not clear what's going on there. IIUC, the underlying C code has a similar structure. Maybe in theory the EvalState could have multiple stores associated with it, but at the moment that's not how it works in practice. Also, in theory we could have one Store associated with multiple EvalStates, but in practice it doesn't actually matter, because Store is already a smart pointer to an underlying c struct, and can be cloned.

Places that should maybe have documentation: