nixops4 / nixops4

Deploy with Nix and manage resources declaratively
272 stars 9 forks source link

support `nix_state_create`'s `lookupPath` argument #34

Closed prednaz closed 4 months ago

prednaz commented 4 months ago

added support for nix_state_create's lookupPath argument to EvalState:new(lookup_path: impl Iterator<Item = &str>, store: Store) and a corresponding unit test case.

This work is sponsored by Antithesis

roberth commented 4 months ago

Hey sorry about the rebase of the bindings branch. To fix the conflicts, I think you could

prednaz commented 4 months ago

no worries, git cherry-pick made short work of this and i am happy to have realise-string's progress available in the bindings branch.

i changed the argument order and expect an IntoIterator instead of an Iterator since that is apparently better in every way. thanks a lot, @ErinvanderVeen, for pointing that out!