search

nixpkgs-architecture / simple-package-paths

Nix RFC draft for auto-calling packages in nixpkgs
18 stars 1 forks source link

Make sure Nix lazy trees is not regression #2

Closed infinisil closed 1 year ago

infinisil commented 2 years ago

Mentioned by @tomberek, see https://github.com/NixOS/nix/pull/6530

roberth commented 2 years ago

Assuming we use sharding, if it regresses, it's a performance regression (or the Nix Team didn't do its job), which will most likely be related to builtins.readDir, which is easy to fix by enumerating the directory structure in a file. Such a file can be generated easily and is subject to fewer changes, so it is still an improvement over all-packages.nix.

infinisil commented 1 year ago

We shouldn't be concerned with this, it's up to Nix to ensure it doesn't break compatibility